Skip to content

Commit

Permalink
RJS-2870: Remove an unused header from the iOS and unused import from…
Browse files Browse the repository at this point in the history
… Android binding (#6812)

* Update RealmReactModule.mm to avoid including an unused header

This fixes #6808

* Update RealmReactModule.java to avoid importing an unused class

* Adding a note to the changelog
  • Loading branch information
kraenhansen authored Jul 25, 2024
1 parent f3db7f1 commit a431b86
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 7 deletions.
7 changes: 2 additions & 5 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,15 @@
* None

### Fixed
* <How to hit and notice issue? what was the impact?> ([#????](https://github.com/realm/realm-js/issues/????), since v?.?.?)
* None
* Fixed compiler error when building binding for React Native iOS: "'React-featureflags/react/featureflags/ReactNativeFeatureFlags.h' file not found" ([#6808](https://github.com/realm/realm-js/issues/6808), since v12.12.0)

### Compatibility
* React Native >= v0.71.4
* Realm Studio v15.0.0.
* File format: generates Realms with format v24 (reads and upgrades file format v10).

### Internal
<!-- * Either mention core version or upgrade -->
<!-- * Using Realm Core vX.Y.Z -->
<!-- * Upgraded Realm Core from vX.Y.Z to vA.B.C -->
* Removed an unused import in the binding for React Native Android. ([#6808](https://github.com/realm/realm-js/issues/6808), since v12.12.0)

## 12.12.0 (2024-07-23)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
import com.facebook.react.bridge.ReactApplicationContext;
import com.facebook.react.bridge.ReactContextBaseJavaModule;
import com.facebook.react.bridge.ReactMethod;
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlags;
import com.facebook.react.module.annotations.ReactModule;
import com.facebook.react.turbomodule.core.interfaces.CallInvokerHolder;
import com.facebook.soloader.SoLoader;
Expand Down
1 change: 0 additions & 1 deletion packages/realm/binding/apple/RealmReactModule.mm
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
#import <React/RCTBridge+Private.h>
#import <React/RCTInvalidating.h>
#import <ReactCommon/CallInvoker.h>
#import <React-featureflags/react/featureflags/ReactNativeFeatureFlags.h>
#import <jsi/jsi.h>

#import <arpa/inet.h>
Expand Down

0 comments on commit a431b86

Please sign in to comment.