Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set primary key column before migration function is called #8057

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented Jan 2, 2025

This is fixing a regression introduced by f7c8e97. The change done in this commit is reverted. Instead the primary key column is set in the post migration changes.

What, How & Why?

Fixes #8056

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

This is fixing a regression introduced by f7c8e97. The change done in
this commit is reverted. Instead the primary key column is set in the
post migration changes.
Copy link

Pull Request Test Coverage Report for Build jorgen.edelbo_478

Details

  • 54 of 54 (100.0%) changed or added relevant lines in 2 files are covered.
  • 47 unchanged lines in 16 files lost coverage.
  • Overall coverage increased (+0.01%) to 91.11%

Files with Coverage Reduction New Missed Lines %
src/realm/dictionary.cpp 1 85.16%
src/realm/sync/network/websocket.cpp 1 72.2%
src/realm/util/compression.cpp 1 89.81%
src/realm/util/file.cpp 1 84.84%
test/test_index_string.cpp 1 93.48%
test/test_query2.cpp 1 98.73%
src/realm/table_view.cpp 2 92.99%
test/fuzz_group.cpp 2 49.28%
test/object-store/sync/flx_sync.cpp 2 98.35%
test/test_lang_bind_helper.cpp 2 93.2%
Totals Coverage Status
Change from base Build 2636: 0.01%
Covered Lines: 217283
Relevant Lines: 238483

💛 - Coveralls

@jedelbo jedelbo requested a review from ironage January 2, 2025 18:06
Copy link
Contributor

@ironage ironage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jedelbo jedelbo merged commit c3fba11 into master Jan 3, 2025
44 of 48 checks passed
@jedelbo jedelbo deleted the je/fix-migration branch January 3, 2025 08:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing type of primary key column crashes if more than one object
2 participants