Fix history command tool #7774
Merged
Fix history command tool #7774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieltabacaru
added
the
no-jira-ticket
Pull Request Test Coverage Report for Build daniel.tabacaru_845Details
💛 - Coveralls |
jbreams
reviewed
Jun 5, 2024
| @@ -2242,7 +2242,7 @@ int main(int argc, char* argv[]) | |||
| Group group{realm_path, encryption_key_3}; // Throws | |||
| using gf = _impl::GroupFriend; | |||
| int file_format_version = gf::get_file_format_version(group); | |||
| if (file_format_version != 23) { | |||
| if (file_format_version != 24) { | |||
There was a problem hiding this comment.
This seems correct for the current file format version, but could we call this Group::read_only_version_check() to check if the file format is valid to read rather than checking a hardcoded version?
jbreams
approved these changes
Aug 22, 2024
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Update history command tool to support realm files with file format v24.
☑️ ToDos
[ ] 📝 Changelog update[ ] 🚦 Tests (or not relevant)[ ] C-API, if public C++ API changed[ ]bindgen/spec.yml, if public C++ API changed