Skip to content

Flyout: use theme default for position #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Flyout: use theme default for position #482

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39d26d3
Flyout: use theme default for `position`
humitos Jan 8, 2025
478cfda
Use a conditional to set the reactive property
humitos Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/flyout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,19 @@ export class FlyoutElement extends LitElement {
return;
}
this.config = config;

// The "position" is a value that can be defined from the dashboard.
// There are two main options: "Default" or a specific value.
// When "Default" is used, the value will be grabbed from the HTML element (e.g. explicitly set by the theme author).
// In case it's not defined, the value defined in the `constructor` will be used ("bottom-right")
const dashboardPosition = objectPath.get(
this.config,
"addons.flyout.position",
null,
);
if (dashboardPosition) {
this.position = dashboardPosition;
}
}

_close() {
Expand Down