Skip to content

Hotkeys: do not trigger them on textarea HTML elements #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 28, 2023
Merged

Hotkeys: do not trigger them on textarea HTML elements #206

merged 2 commits into from
Nov 28, 2023

Conversation

humitos
Copy link
Member

@humitos humitos commented Nov 28, 2023

Closes #205

@humitos humitos requested a review from davidfischer November 28, 2023 10:11
@humitos humitos requested a review from a team as a code owner November 28, 2023 10:11
@humitos humitos requested a review from agjohnson November 28, 2023 10:11
davidfischer
davidfischer approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@davidfischer davidfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it should work. I'm sure there's some people out there doing weird things so the sooner we make this really easy to disable the better.

@humitos
Copy link
Member Author

humitos commented Nov 28, 2023

I'm sure there's some people out there doing weird things so the sooner we make this really easy to disable the better.

Yeah, definitely. We are tracking this at readthedocs/ext-theme#211

If you want me to disable the hotkeys in your project, I can do that from the Django admin for now.

@humitos humitos merged commit ef83b9b into main Nov 28, 2023
@humitos humitos deleted the humitos/hotkeys-textarea branch November 28, 2023 19:10
@davidfischer
Copy link
Contributor

If you want me to disable the hotkeys in your project, I can do that from the Django admin for now.

We already disabled it =).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfischer davidfischer davidfischer approved these changes

@agjohnson agjohnson Awaiting requested review from agjohnson agjohnson is a code owner automatically assigned from readthedocs/frontend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docdiff should not apply the 'd' hotkey in textareas
2 participants
@humitos @davidfischer