Skip to content

Add translation for ReactDOM API reference #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 8, 2019

Conversation

Manugal
Copy link
Contributor

@Manugal Manugal commented Mar 5, 2019

Ciao.

This is the translation for ReactDOM API reference.

@netlify
Copy link

netlify bot commented Mar 5, 2019

Deploy preview for it-react-org ready!

Built with commit f3ddb3a

https://deploy-preview-121--it-react-org.netlify.com

@netlify
Copy link

netlify bot commented Mar 5, 2019

Deploy preview for it-reactjs ready!

Built with commit f3ddb3a

https://deploy-preview-121--it-reactjs.netlify.com

@deblasis
Copy link
Collaborator

deblasis commented Mar 6, 2019

Closes #28

@deblasis deblasis added needs +1 Needs an approval before merging (not from the author) 💪 long page - more than 100 lines Looooong page, expect delays! labels Mar 6, 2019
Copy link
Collaborator

@deblasis deblasis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@deblasis deblasis added 🤓 in review and removed needs +1 Needs an approval before merging (not from the author) labels Mar 7, 2019
@Manugal
Copy link
Contributor Author

Manugal commented Mar 8, 2019

Ciao.

Do I have to take some further action other than resolving conversations? Yesterday, I committed the changes requested.

@deblasis
Copy link
Collaborator

deblasis commented Mar 8, 2019

Ciao! There's still an item pending as far as I can see 😄

@Manugal
Copy link
Contributor Author

Manugal commented Mar 8, 2019

Sorry, I don't know how to remove this pending item. I had accepted some proposed changes, but for two of them I only resolved the conversation because changes were not needed.

@deblasis
Copy link
Collaborator

deblasis commented Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 long page - more than 100 lines Looooong page, expect delays!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants