Skip to content

Translation for the page 'React.Component' #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 18, 2019
Merged

Translation for the page 'React.Component' #118

merged 9 commits into from
Mar 18, 2019

Conversation

LucaBlackDragon
Copy link
Collaborator

@LucaBlackDragon LucaBlackDragon commented Mar 3, 2019 •
edited
Loading

Closes #27

@LucaBlackDragon LucaBlackDragon added needs +1 Needs an approval before merging (not from the author) 🏗️ Work in progress Work in progress labels Mar 3, 2019
@tesseralis tesseralis mentioned this pull request Mar 3, 2019
Closed
@LucaBlackDragon LucaBlackDragon mentioned this pull request Mar 3, 2019
Closed
@netlify
Copy link

netlify bot commented Mar 3, 2019 •
edited
Loading

Deploy preview for it-react-org ready!

Built with commit 4dc0d06

https://deploy-preview-118--it-react-org.netlify.com

@netlify
Copy link

netlify bot commented Mar 3, 2019 •
edited
Loading

Deploy preview for it-reactjs ready!

Built with commit 4dc0d06

https://deploy-preview-118--it-reactjs.netlify.com

@LucaBlackDragon LucaBlackDragon mentioned this pull request Mar 4, 2019
Closed
@LucaBlackDragon LucaBlackDragon marked this pull request as ready for review March 11, 2019 13:38
@LucaBlackDragon LucaBlackDragon requested a review from lssmn March 11, 2019 13:38
@LucaBlackDragon
Copy link
Collaborator Author

LucaBlackDragon commented Mar 11, 2019 •
edited
Loading

@deblasis @lssmn it has been particularly difficult to work on this page, as I had to translate a lot of code samples and make a lot of critical choices regarding terminology, including how to translate "error boundary" (I went for "contenitore di errori").
Please check it thoroughly and feel free to change/criticize/improve whatever you want!

@deblasis
Copy link
Collaborator

Hey @LucaBlackDragon ! Wow this is a huge one! I'll have a look later tomorrow I hope.
Meanwhile, there's an issue with prettier:
image
That breaks the build, run the command with the --write option and it should fix that for you.
Let me know if you need help
Ciao!

deblasis
deblasis requested changes Mar 18, 2019
View reviewed changes
Copy link
Collaborator

@deblasis deblasis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@deblasis deblasis removed the needs +1 Needs an approval before merging (not from the author) label Mar 18, 2019
deblasis and others added 2 commits March 18, 2019 14:34
@deblasis @LucaBlackDragon
Apply suggestions from code review
bdd4ba4 
Too many typos!!! XD

Co-Authored-By: LucaBlackDragon <[email protected]>
Fix broken build
4dc0d06
@deblasis deblasis merged commit b2369bd into master Mar 18, 2019
@LucaBlackDragon LucaBlackDragon deleted the react-component branch August 17, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deblasis deblasis deblasis approved these changes

@lssmn lssmn Awaiting requested review from lssmn

Assignees
No one assigned
Labels
🐘 huge - more than 500 lines ✔ translated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucaBlackDragon @deblasis