-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(upgrade) Prepare v 1.2.0 #60
Conversation
aesteve
commented
Mar 14, 2023
- Upgrade Vert.x to 4.4.0
- Upgrade AWS SDK to 2.1109
* Upgrade AWS SDK to 2.1109
This doesn't fail on my m1 with java17 and @LocalstackDockerProperties(services = { "s3" }, imageTag = "1.4.0-arm64") though its skipping VertxLambdaClientSpec |
Yes for the Localstack tests to run (kind of Integration testing) you have to specifiy EDIT: Oh sorry you were only mentioning the |
* Use Gradle 8
# Conflicts: # .github/workflows/ci-snapshot.yml
Thanks a lot @chris-brace ! It works with the latest Localstack version indeed. May I ask you to give: 1.2.0-SNAPSHOT a try? If you can? If it looks good for you I'll be able to publish the release. |
@aesteve its funny, i did these changes locally about 2 days ago and they work but i will pull this branch and run the tests |
tests run with no modification on my m1 when i pull this branch. our integration tests (a very large volume, some of which use AWS testing resources for sqs/s3/kms/sts) appear fine. |
Awesome, let's merge this and publish 1.2.0 then! |
Sorry I forgot to notify you @chris-brace : 1.2.0 has been released over the weekend: https://central.sonatype.com/artifact/io.reactiverse/aws-sdk/1.1.0/versions |