Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(upgrade) Prepare v 1.2.0 #60

Merged
merged 8 commits into from
Mar 18, 2023
Merged

(upgrade) Prepare v 1.2.0 #60

merged 8 commits into from
Mar 18, 2023

Conversation

aesteve
Copy link
Collaborator

@aesteve aesteve commented Mar 14, 2023

  • Upgrade Vert.x to 4.4.0
  • Upgrade AWS SDK to 2.1109

@chris-brace
Copy link
Contributor

chris-brace commented Mar 14, 2023

This doesn't fail on my m1 with java17 and

@LocalstackDockerProperties(services = { "s3" }, imageTag = "1.4.0-arm64")

though its skipping VertxLambdaClientSpec

@aesteve
Copy link
Collaborator Author

aesteve commented Mar 15, 2023

Yes for the Localstack tests to run (kind of Integration testing) you have to specifiy -Dtests.integration=localstack

Example in IntelliJ:
Screenshot 2023-03-15 at 08 43 05

EDIT: Oh sorry you were only mentioning the VertxLambdaClientSpecbeing ignored. Yes I had to disable this one.
Sorry I get your point now. So it's working for you with 1.4.0, I'll check on my side.

@aesteve
Copy link
Collaborator Author

aesteve commented Mar 15, 2023

Thanks a lot @chris-brace ! It works with the latest Localstack version indeed.

May I ask you to give: 1.2.0-SNAPSHOT a try? If you can?

If it looks good for you I'll be able to publish the release.

@chris-brace
Copy link
Contributor

@aesteve its funny, i did these changes locally about 2 days ago and they work but i will pull this branch and run the tests

@chris-brace
Copy link
Contributor

tests run with no modification on my m1 when i pull this branch. our integration tests (a very large volume, some of which use AWS testing resources for sqs/s3/kms/sts) appear fine.

@aesteve
Copy link
Collaborator Author

aesteve commented Mar 18, 2023

Awesome, let's merge this and publish 1.2.0 then!

@aesteve aesteve merged commit e63d304 into master Mar 18, 2023
@aesteve
Copy link
Collaborator Author

aesteve commented Mar 21, 2023

Sorry I forgot to notify you @chris-brace : 1.2.0 has been released over the weekend: https://central.sonatype.com/artifact/io.reactiverse/aws-sdk/1.1.0/versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants