-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trying to implement an AsyncResponseTransformer #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st-h
reviewed
Oct 20, 2019
src/main/java/io/reactiverse/awssdk/converters/VertxAsyncResponseTransformer.java
Show resolved
Hide resolved
st-h
reviewed
Oct 20, 2019
src/main/java/io/reactiverse/awssdk/converters/VertxAsyncResponseTransformer.java
Show resolved
Hide resolved
st-h
reviewed
Oct 20, 2019
src/main/java/io/reactiverse/awssdk/converters/VertxAsyncResponseTransformer.java
Outdated
Show resolved
Hide resolved
st-h
suggested changes
Oct 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aesteve I think I found a little bug, which appears when using the transformer without invoking setResponseHandler
@Override
public void onResponse(ResponseT response) {
// this.responseHandler == null if setResponseHandler is not invoked
this.responseHandler.ifPresent(handler -> handler.handle(response));
}
src/main/java/io/reactiverse/awssdk/converters/VertxAsyncResponseTransformer.java
Outdated
Show resolved
Hide resolved
src/main/java/io/reactiverse/awssdk/converters/VertxAsyncResponseTransformer.java
Show resolved
Hide resolved
Thanks for your reports, I've merged it. |
@aesteve awesome. Thanks a lot for your work and help on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.