Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to implement an AsyncResponseTransformer #36

Merged
merged 3 commits into from
Nov 11, 2019

Conversation

aesteve
Copy link
Collaborator

@aesteve aesteve commented Oct 20, 2019

No description provided.

@aesteve aesteve added the enhancement New feature or request label Oct 20, 2019
@aesteve aesteve requested a review from vietj October 20, 2019 07:11
@aesteve aesteve self-assigned this Oct 20, 2019
@aesteve aesteve changed the title [WIP] Trying to implement an AsyncResponseTransformer Trying to implement an AsyncResponseTransformer Oct 24, 2019
Copy link

@st-h st-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aesteve I think I found a little bug, which appears when using the transformer without invoking setResponseHandler

@Override
public void onResponse(ResponseT response) {
    // this.responseHandler == null if setResponseHandler is not invoked
    this.responseHandler.ifPresent(handler -> handler.handle(response));
}

@aesteve aesteve merged commit 390b42a into master Nov 11, 2019
@aesteve
Copy link
Collaborator Author

aesteve commented Nov 11, 2019

Thanks for your reports, I've merged it.

@st-h
Copy link

st-h commented Nov 12, 2019

@aesteve awesome. Thanks a lot for your work and help on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants