-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set fix localstack container version and set keep-alive header manually / explicit #31
Set fix localstack container version and set keep-alive header manually / explicit #31
Conversation
…th localstack-utils library. Like localstack/localstack#1569
5e4d0b4
to
b1a301d
Compare
Tests are working locally (but on my laptop they always did). |
The problem will happen when you pull the currently latest Localstack image (0.10.3). If you locally already has the 0.10.2 and you don't pull, it will work |
Thanks a lot, may I ask you something, please? Would you mind changing: https://github.com/reactiverse/aws-sdk/blob/master/.travis.yml#L16 to:
in your branch? So that we can see if Travis build now passes? We'll merge your work anyway, and thanks a lot btw. But it'd be really awesome if your changes fix the Travis build! |
Done, but still fail. I dont now Travis, is the runner a new instance? It looks like there is maybe already a Localstack container instance running from a previous test run? A fun fact is as well, that the busy port is the one of CloudFormation which is useless in the tests. Another question. Are you interested in Kotlin extensions for this library in a separate sub-lib like aws-sdk-lang-kotlin? I think about a collection of AWS SDK extensions with the Await approach, like most of the other Vert.x libraries have. |
Ok, I can see on Travis it's still failing unfortunately :( |
.travis.yml
Outdated
@@ -13,7 +13,7 @@ jobs: | |||
- stage: test | |||
name: Build on OpenJDK 8 | |||
jdk: openjdk8 | |||
script: ./gradlew --no-daemon -i --stacktrace jacocoTestReport | |||
script: ./gradlew --no-daemon -i -Dtests.integration=localstack --stacktrace jacocoTestReport |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
script: ./gradlew --no-daemon -i -Dtests.integration=localstack --stacktrace jacocoTestReport | |
script: ./gradlew --no-daemon -i --stacktrace jacocoTestReport |
Back to the "non-integration" tests
Regarding your other question, I have to think. |
@wem could you please revert the change I requested above, please. So that we can merge your work :) (I don't have permission to "apply suggestion", unfortunately). Thank you. |
Hi @aesteve , i will do it this evening. Sorry for delay. |
528032f
to
b1a301d
Compare
Done |
Thanks a lot. I'll just take your question out of this PR to open an issue, so that we don't forget about it. Thanks a lot for your contribution. |
No description provided.