Skip to content

enhance: Transform updateParams to 'update' function #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2021

Conversation

ntucker
Copy link
Collaborator

@ntucker ntucker commented May 24, 2021

Motivation

As promised in #843 - as part of legacy plan we will only send update functions.

Solution

Convert updateParams to update function in core's createFetch().

Will not merge with endpoint.update - instead overrides for simplicity.

@ntucker ntucker requested a review from ljharb May 24, 2021 18:44
@ntucker ntucker changed the title Enhance/updateparam to update enhance: Transform updateParams to 'update' function May 24, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2021

Size Change: +78 B (0%)

Total Size: 142 kB

Filename Size Change
packages/core/dist/index.cjs.js 12 kB +73 B (0%)
packages/core/dist/index.umd.min.js 5.21 kB +5 B (0%)
ℹ️ View Unchanged
Filename Size Change
packages/endpoint/dist/index.cjs.js 2.01 kB 0 B
packages/endpoint/dist/index.umd.min.js 1.42 kB 0 B
packages/experimental/dist/index.cjs.js 8.42 kB 0 B
packages/experimental/dist/index.umd.min.js 3.06 kB 0 B
packages/hooks/dist/index.cjs.js 8.28 kB 0 B
packages/hooks/dist/index.umd.min.js 3.01 kB 0 B
packages/img/dist/index.cjs.js 7.82 kB 0 B
packages/img/dist/index.umd.min.js 2.9 kB 0 B
packages/legacy/dist/index.cjs.js 578 B 0 B
packages/legacy/dist/index.umd.min.js 517 B 0 B
packages/normalizr/dist/normalizr.amd.js 10.8 kB 0 B
packages/normalizr/dist/normalizr.amd.min.js 5.89 kB 0 B
packages/normalizr/dist/normalizr.browser.js 10.8 kB 0 B
packages/normalizr/dist/normalizr.browser.min.js 5.89 kB 0 B
packages/normalizr/dist/normalizr.js 10.7 kB 0 B
packages/normalizr/dist/normalizr.min.js 5.9 kB 0 B
packages/normalizr/dist/normalizr.umd.js 10.9 kB 0 B
packages/normalizr/dist/normalizr.umd.min.js 5.97 kB 0 B
packages/rest-hooks/dist/index.cjs.js 8.04 kB 0 B
packages/rest-hooks/dist/index.umd.min.js 4.31 kB 0 B
packages/rest/dist/index.cjs.js 4.1 kB 0 B
packages/rest/dist/index.umd.min.js 2.19 kB 0 B
packages/use-enhanced-reducer/dist/index.cjs.js 1.08 kB 0 B
packages/use-enhanced-reducer/dist/index.umd.min.js 607 B 0 B

compressed-size-action

@ntucker ntucker force-pushed the enhance/updateparam-to-update branch from 0031af2 to 2935ed5 Compare May 24, 2021 19:48
@ntucker ntucker merged commit 7ef3e2a into master May 24, 2021
@ntucker ntucker deleted the enhance/updateparam-to-update branch May 24, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants