Better async effect shutdown behavior #1267
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Asynchronous code is fundamentally tricky to handle, given issues with race conditions and task cancellation. This is significant to us since we currently support asynchronous effects within
use_async_effect
.This PR attempts to alleviate some of those concerns by giving asynchronous effect functions a small amount of time (configurable) to finish executing before being forcibly shutdown.
Additionally, this PR refactors
use_effect
code to be human-readable.Predecessor PR:
use_async_effect
hook #1264Checklist
Please update this checklist as you complete each item:
By submitting this pull request I agree that all contributions comply with this project's open source license(s).