Skip to content

Add missing changelog header #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2025
Merged

Add missing changelog header #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e5e462
Add missing changelog header
Archmonger Jan 11, 2025
85a9e3f
Attempt to fix tests
Archmonger Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ Don't forget to remove deprecated code on each major release!

### [5.2.1] - 2025-01-10

### Changed

- Use the latest version of `@reactpy/client` which includes a fix for needless client-side component re-creation.

### [5.2.0] - 2024-12-29
Expand Down
6 changes: 0 additions & 6 deletions tests/test_app/tests/js/button-from-js-module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
import { h, render } from "https://unpkg.com/preact?module";
import htm from "https://unpkg.com/htm?module";

const html = htm.bind(h);

export function bind(node, config) {
return {
Expand All @@ -16,9 +13,6 @@ export function SimpleButton(props) {
"button",
{
id: props.id,
onClick(event) {
props.onClick({ data: props.eventResponseData });
},
},
"simple button",
);
Expand Down
2 changes: 1 addition & 1 deletion tests/test_app/tests/test_components.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ def test_component_session_exists(self):
@navigate_to_page("/")
def test_component_session_missing(self):
"""No session should exist for components that don't have args/kwargs."""
component = self.page.locator("#button-from-js-module")
component = self.page.locator("#use-scope")
component.wait_for()
parent = component.locator("..")
session_id = parent.get_attribute("id")
Expand Down
Loading