This repository has been archived by the owner on Sep 21, 2022. It is now read-only.
Update decodeOpaqueId.js #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required in order to be consistent with: https://github.com/reactioncommerce/api-utils/blob/f7690705c49c4a0d94799ed3deaf6be9ff909f76/lib/encodeOpaqueId.js#L20 Since the entire encoding/decoding of IDs was built for a reason that is no longer valid, we've found it very practical to simply set the environment variable REACTION_SHOULD_ENCODE_IDS to false. This makes development considerably easier, especially for quick API tests with graphQL playground. But in order for that to work, `decodeOpaqueId()` should also check for the env variable. If we don't do that, `decodeOpaqueId()` can return wrong `namespace` and `id` values. (Note that `decodeOpaqueId()` did NOT always fail prior to our change. For example, decoding ID `xifjgK9ckbptZ2ew2 ` will yield a null namespace and return the ID as is, whereas decoding ID `dTp6az9ghgoLSGGTo` will yield a namespace equal to `u` and a wrong ID) Signed-off-by: hrhosni <[email protected]>
hrhosni
force-pushed
the
patch-1
branch
2 times, most recently
from
043d1e9 to
a9ab566
Compare
Signed-off-by: hrhosni <[email protected]>
Signed-off-by: hrhosni <[email protected]>
Signed-off-by: hrhosni <[email protected]>
Signed-off-by: hrhosni <[email protected]>
|
Hi @mpaktiti @mikemurray, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required in order to be consistent with:
api-utils/lib/encodeOpaqueId.js
Line 20 in f769070
Since the entire encoding/decoding of IDs was built for a reason that is no longer valid, we've found it very practical to simply set the environment variable REACTION_SHOULD_ENCODE_IDS to false. This makes development considerably easier, especially for quick API tests with graphQL playground.
But in order for that to work,
decodeOpaqueId()should also check for the env variable. If we don't do that,decodeOpaqueId()can return wrongnamespaceandidvalues.(Note that
decodeOpaqueId()did NOT always fail prior to our change. For example, decodingreaction/mediaRecord:xifjgK9ckbptZ2ew2will yield a null namespace and return the ID as is (because there's no:character to split on I believe), whereas decoding IDreaction/mediaRecord:dTp6az9ghgoLSGGTowill yield a namespace equal touand a wrong ID)