Extract react/bridging into its own React-bridging pod#57354
Open
javache wants to merge 1 commit into
Open
Conversation
Summary: Split the `react/bridging` headers out of the `ReactCommon` pod's `turbomodule/bridging` subspec into a standalone `React-bridging` podspec, mirroring the existing `React-bridging` SwiftPM target. This makes bridging a dependency-graph leaf so other modules can depend on it without pulling in `ReactCommon` / `React-cxxreact`. Consumers that previously reached `react/bridging` headers transitively through `ReactCommon` now resolve them through the standalone pod. The CocoaPods header-search-path injection in `update_search_paths` lists `React-bridging` alongside the other core frameworks so the headers resolve everywhere, and pods that link the `LongLivedObject` / `CallbackWrapper` symbols (`React-Fabric`, the nativemodule feature pods, `React-NativeModulesApple`, `React-RCTFBReactNativeSpec`) gain an explicit `React-bridging` dependency. All `ReactCommon/turbomodule/bridging` references in podspecs, the autolinker, the codegen template, and their test snapshots are repointed to `React-bridging`. Changelog: [Internal] Differential Revision: D109868509
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109868509. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Split the
react/bridgingheaders out of theReactCommonpod'sturbomodule/bridgingsubspec into a standaloneReact-bridgingpodspec, mirroring the existingReact-bridgingSwiftPM target. This makes bridging a dependency-graph leaf so other modules can depend on it without pulling inReactCommon/React-cxxreact.Consumers that previously reached
react/bridgingheaders transitively throughReactCommonnow resolve them through the standalone pod. The CocoaPods header-search-path injection inupdate_search_pathslistsReact-bridgingalongside the other core frameworks so the headers resolve everywhere, and pods that link theLongLivedObject/CallbackWrappersymbols (React-Fabric, the nativemodule feature pods,React-NativeModulesApple,React-RCTFBReactNativeSpec) gain an explicitReact-bridgingdependency. AllReactCommon/turbomodule/bridgingreferences in podspecs, the autolinker, the codegen template, and their test snapshots are repointed toReact-bridging.Changelog:
[Internal]
Differential Revision: D109868509