Guard statusBarShow/statusBarHide against detached decorView (#57342)#57342
Closed
alanleedev wants to merge 1 commit into
Closed
Guard statusBarShow/statusBarHide against detached decorView (#57342)#57342alanleedev wants to merge 1 commit into
alanleedev wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@alanleedev has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107934787. |
…7342) Summary: Pull Request resolved: react#57342 `statusBarShow()` and `statusBarHide()` access the window's `decorView`, which throws `IllegalArgumentException` when the decorView is not attached to the window manager. This can happen for extra windows (dialogs/popups) whose decorView is detached independently of the host activity's lifecycle, or when status bar visibility is updated during teardown. Guard both functions with `if (!decorView.isAttachedToWindow) return` so the fix protects every caller at the source. The guard is a no-op during normal operation (the decorView is always attached) and only short-circuits during the teardown race. Changelog: [Android][Fixed] - Prevent `IllegalArgumentException` crash in `statusBarShow`/`statusBarHide` when the window decorView is detached Reviewed By: Abbondanzo Differential Revision: D107934787
alanleedev
force-pushed
the
export-D107934787
branch
from
55db3cb to
a327c20
Compare
meta-codesync
Bot
changed the title
|
This pull request has been merged in a54b04e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
statusBarShow()andstatusBarHide()access the window'sdecorView, which throwsIllegalArgumentExceptionwhen the decorView is not attached to the window manager. This can happen for extra windows (dialogs/popups) whose decorView is detached independently of the host activity's lifecycle, or when status bar visibility is updated during teardown.Guard both functions with
if (!decorView.isAttachedToWindow) returnso the fix protects every caller at the source. The guard is a no-op during normal operation (the decorView is always attached) and only short-circuits during the teardown race.Changelog:
[Android][Fixed] - Prevent
IllegalArgumentExceptioncrash instatusBarShow/statusBarHidewhen the window decorView is detachedReviewed By: Abbondanzo
Differential Revision: D107934787