Conversation
## Summary Metro's dev server sets `Content-Type` with `mime.lookup()`, both for `/assets/` and for source files under `/[metro-project]/`. That returns a bare type like `text/html` with no charset, so clients fall back to their own default - #859 is a `WebView` rendering a UTF-8 `.html` asset as mojibake. `mime-types` has `contentType()` for this. It appends `; charset=utf-8` where a charset applies and is otherwise identical, including returning `false` for an unrecognised extension, so binary assets are unaffected. Fixes: #859 Changelog: ``` - **[Fix]**: Include `charset=utf-8` in the `Content-Type` of text assets and source files served by the dev server ``` ## Test plan ``` yarn jest packages/metro/src/Server yarn flow check ``` New cases for a text asset, a source file and a binary file. The charset assertions fail on `main`.
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
Contributor
|
@vzaidman has imported this pull request. If you are a Meta employee, you can view this in D118437775. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Metro's dev server sets
Content-Typewithmime.lookup(), both for/assets/and for source files under/[metro-project]/. That returns a bare type liketext/htmlwith no charset, so clients fall back to their own default - #859 is aWebViewrendering a UTF-8.htmlasset as mojibake.mime-typeshascontentType()for this. It appends; charset=utf-8where a charset applies and is otherwise identical, including returningfalsefor an unrecognised extension, so binary assets are unaffected.Fixes: #859
Changelog:
Test plan
New cases for a text asset, a source file and a binary file. The charset assertions fail on
main.