Skip to content

Fix library in android #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix library in android #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# react-native-network-state
# react-native-network-state-connect-internet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@linhndbtc-studio Do you have explanation for this line?
Doesn't it completely switch to new npm package which is not relevant to this repo?


[![NPM](https://nodei.co/npm/react-native-network-state.png)](https://nodei.co/npm/react-native-network-state/)

Expand All @@ -20,11 +20,11 @@

or

`$ yarn add react-native-network-state`
`$ yarn add react-native-network-state-connect-internet`

### Automatic installation

`$ react-native link react-native-network-state`
`$ react-native link react-native-network-state-connect-internet`

### Manual installation

Expand Down
6 changes: 4 additions & 2 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ repositories {
}

dependencies {
compile 'com.github.pwittchen:reactivenetwork-rx2:2.1.0'
compile 'com.facebook.react:react-native:+'
implementation 'com.github.pwittchen:reactivenetwork-rx2:2.1.0'
implementation 'com.facebook.react:react-native:+'
implementation 'androidx.appcompat:appcompat:1.0.2'
implementation 'androidx.annotation:annotation:1.0.2'
}
3 changes: 2 additions & 1 deletion android/src/main/java/com/reactnativevietnam/RNNetworkModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
import android.net.ConnectivityManager;
import android.net.NetworkInfo;
import android.provider.Settings;
import android.support.annotation.Nullable;
// import android.support.annotation.Nullable;
import androidx.annotation.Nullable;
import android.telephony.TelephonyManager;

import com.facebook.react.ReactApplication;
Expand Down