Skip to content

added accessibility id as a locator #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2024
Merged

added accessibility id as a locator #896

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e750891
added accessibility id as a locator
rvenky125 Oct 31, 2024
3e44ee5
addressed lint checks
rvenky125 Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion js/SegmentedControlTab.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
TouchableOpacity,
View,
useColorScheme,
Platform

Check failure on line 16 in js/SegmentedControlTab.js

View workflow job for this annotation

GitHub Actions / lint (20) 

Insert `,`

Check warning on line 16 in js/SegmentedControlTab.js

View workflow job for this annotation

GitHub Actions / lint (20) 

Missing trailing comma
} from 'react-native';

import type {FontStyle, ViewStyle} from './types';
Expand Down Expand Up @@ -95,7 +96,9 @@
accessibilityHint={accessibilityHint}
accessibilityRole="button"
accessibilityState={{selected: selected, disabled: !enabled}}
testID={testID}>
testID={testID}
accessible={true}

Check warning on line 100 in js/SegmentedControlTab.js

View workflow job for this annotation

GitHub Actions / lint (20) 

Trailing spaces not allowed

Check failure on line 100 in js/SegmentedControlTab.js

View workflow job for this annotation

GitHub Actions / lint (20) 

Delete `·`
accessibilityLabel={Platform.select({android: testID, ios: value == 'string' ? value : testID})}>

Check failure on line 101 in js/SegmentedControlTab.js

View workflow job for this annotation

GitHub Actions / lint (20) 

Replace `android:·testID,·ios:·value·==·'string'·?·value·:·testID` with `⏎········android:·testID,⏎········ios:·value·==·'string'·?·value·:·testID,⏎······`

Check warning on line 101 in js/SegmentedControlTab.js

View workflow job for this annotation

GitHub Actions / lint (20) 

Expected '===' and instead saw '=='
<View style={styles.default}>
{typeof value === 'number' || typeof value === 'object' ? (
<Image source={value} style={styles.segmentImage} />
Expand Down
Loading