Skip to content

feat: set areAllCollapsed as true in done section (fixes #403) #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adrielfabricio
Copy link

Summary

This pull request Resolves #403.

It implements automatic collapse for files marked as completed. The logic was implemented by modifying the useState hook to check whether the current section is Done; if so, the areAllCollapsed variable is set to true by default.

This change improves the user experience by reducing visual clutter in the "Done" section.

Test Plan

Steps to Reproduce

  1. Add a comparison between two versions of React Native.
  2. Mark any file as completed.
  3. Go to the Done section and confirm that the completed file is automatically collapsed.

Checklist

  • I tested this thoroughly
  • I added documentation in README.md (if needed)

@pvinis
Copy link
Member

pvinis commented Jul 10, 2025

waiting for the preview to test, but I don't think this resolves the issue. when I mark the first individual file as done, it should move down and also collapse.

Copy link
Member

@pvinis pvinis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad. it totally makes sense. thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When a file is marked as done, it should collapse too.
2 participants