-
Notifications
You must be signed in to change notification settings - Fork 729
feat: add vegaos platform compatibility
#1921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add vegaos platform compatibility
#1921
Conversation
|
Hey @moskalakamil, thanks for working on those changes! 👍 I was think about this a bit for a while, and after digging more few days ago into how Vega OS works currently, I'm not sure if it is not too early to add it to the directory. I wonder what others would think tho. The problems I see at this time:
So if we decide to move on this addition, at this time I would prefer add this as a compatibility flag (just like Expo Go or Fire OS), and not as a separate platform (at least for now). Could you revert the footer change, and refactor the flag to be a compatibility one? This way it should be easier to move the contribution forward. Maybe some Amazon folks (previously responsible for adding Fire OS flag) can chime in, and provide a bit more context on their vision, and the plans for the future, CC @mosesroth, @chris-trag |
|
Totally agree! I actually thought about opening this as a discussion first, but since it was just a quick one-prompt change, I figured I’d throw it in as a PR instead. |
|
Hey @Simek & @moskalakamil - thx so much for the discussion and points here. I agree with Simon that Vega OS & the SDK have several milestones we have to reach during this I'm conscious that we need to earn trust and work through which "ported" libraries should get upstreamed back to the main projects versus living in their current namespaces while we work through compatibility feedback & tv specific feature requests. For now, I love the idea of a compatibility flag for In addition, we're keeping this community post up to date each time we have a new library with support: https://community.amazondeveloper.com/t/vega-supported-libraries-and-services/1552 @moskalakamil let me know if you need any help with the change @Simek recommended for this PR. |
5f47023 to
9a70f03
Compare
vegaos platformvegaos platform compatibility
|
Hey @Simek, I updated the flag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @moskalakamil! 👍
After thinking a bit more about this, we can improve the clarity and avoid the repetition of libraries, if we allow vegaOs field to accept strings which would point out to the alternate Vega OS packages in npm registry, and then link up visual tag on the library tile with that.
The follow up would be to port over the data from mentioned by Chris list to the react-native-libraries.json. Let me know if you are interested on working on those two change, if not we can merge it as-is (with unrelated changes revert), and I can continue the efforts in a follow-up PR.
| > [!TIP] | ||
| > Are you looking for an integration with VS Code? Check out our official extension: | ||
| > * https://github.com/react-native-community/vscode-react-native-directory | ||
| > |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's revert the README.md changes not related to Vega OS addition.
| "required": [ | ||
| "githubUrl" | ||
| ], | ||
| "required": ["githubUrl"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's revert schema changes not related to Vega OS.
📝 Why & how
Hey folks 👋
I added support for the Vega OS platform and wanted to leave this PR open for some discussion.
So far, the directory only had “Works with Fire OS,” but since Fire TV devices are moving over to Vega, I figured it might make sense to bring it up here.
Should we keep Vega as a separate platform? Replace Fire OS? Or maybe have both available through filtering?
To mark Vega OS support in a library entry, just add:
{ "githubUrl": "https://github.com/user/library", "vegaos": true }This is just a trial addition - curious to hear what do you think!
✅ Checklist
react-native-libraries.jsonreact-native-libraries.json