-
Notifications
You must be signed in to change notification settings - Fork 928
chore: switch to tinyglobby #2680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the performance difference between fast-glob
and tinyglobby
?
Looks like the CI for this change is failing because Jest is outdated, so we'll either need to upgrade Jest or wait for a new release of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👌
@benmccann any chance you could measure the perf difference in this project? |
8c21c94
to
c6bf39e
Compare
I've updated this PR to use the latest |
"@types/glob": "^7.1.1", | ||
"@types/jest": "^26.0.15", | ||
"@types/node": "^20.0.0", | ||
"@types/picomatch": "^4.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this? picomatch is a transitive dep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was because of the type-checking during the build process. fdir
(one of the dependencies of tinyglobby
) uses picomatch
in its types, but doesn't declare a dependency on @types/picomatch
, so it failed without this
Summary
https://npmgraph.js.org/?q=fast-glob - 17 dependencies
https://npmgraph.js.org/?q=tinyglobby - 2 dependencies
Test Plan
No new functionality was added, so this should be covered by existing tests
Checklist
react-native
checkout (instructions).