feat: handle better canceling prompts #2138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Oct 27, 2023
| import type {Config as CLIConfig} from '@react-native-community/cli-types'; | ||
| import chalk from 'chalk'; | ||
| import execa from 'execa'; | ||
| import {existsSync as fileExists, rmdir} from 'fs'; | ||
| import os from 'os'; | ||
| import path from 'path'; | ||
| import prompts from 'prompts'; |
There was a problem hiding this comment.
Can we get rid of prompts dependency from cli-clean? And other packages, if feasable
|
Unit tests failing |
szymonrybczak
force-pushed
the
feat/better-handle-aborting-in-prompt
branch
from
db1ad2b to
34ed1c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In this PR I moved all prompts to use internal wrapper that we have in
cli-toolsthat overwritesonCancelmethod with relevant error.Test Plan:
ctrl + cand you should see "Prompt cancelled." error message.Checklist