Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force users to use nodeLinker: node-modules when installing template packages #2135

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

szymonrybczak
Copy link
Collaborator

Summary:

Fixes #1637

We need to be sure that node_modules directory exists, because then we're getting template from it. I tested and that command works in v1, v2, v3.

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@szymonrybczak szymonrybczak force-pushed the feat/force-users-to-use-node-linker branch 2 times, most recently from e3317db to 080ef01 Compare October 26, 2023 20:50
@szymonrybczak szymonrybczak force-pushed the feat/force-users-to-use-node-linker branch from 080ef01 to 17ea79c Compare October 30, 2023 15:23
@thymikee thymikee changed the title feat: force users to use nodeLinker: node-modules when installing template packages fix: force users to use nodeLinker: node-modules when installing template packages Oct 31, 2023
@thymikee thymikee merged commit f433381 into main Oct 31, 2023
@thymikee thymikee deleted the feat/force-users-to-use-node-linker branch October 31, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Couldn't find template.config.js file inside "react-native" template. Please make sure the template is valid
2 participants