Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: opt-in pod install with ios commands #2116

Merged

Conversation

TMisiukiewicz
Copy link
Collaborator

Summary:

Adding new config parameter project.ios.automaticPodsInstallation.

For existing apps, it means developers can opt-in for automatic CocoaPods installation when running run-ios or build-ios. Some projects are running on non-standard setups or pods installation is simply not desired.

For the users using init command starting from 0.73, it will automatically create the react-native.config.js file with this param set to true. File is created by CLI after processing the template.

Test Plan:

  1. Create a project with npx react-native init
  2. Link the CLI packages following the Contributing guide
  3. run-ios and make sure CocoaPods step is skipped
  4. Create react-native.config.js file and set project.ios.automaticPodsInstallation to true
  5. run-ios again and confirm that CocoaPods are getting installed
  6. Create another project with the local CLI node ./path/to/cli init
  7. When prompted about pods installation, press n
  8. Once project is set, confirm react-native.config.js file exists
  9. Run run-ios and verify pods are getting installed

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@github-actions github-actions bot added docs Documentation change feature labels Oct 12, 2023
Copy link
Contributor

@tido64 tido64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this ❤️

packages/cli-platform-ios/src/commands/runIOS/index.ts Outdated Show resolved Hide resolved
packages/cli/src/commands/init/init.ts Outdated Show resolved Hide resolved
packages/cli/src/commands/init/init.ts Outdated Show resolved Hide resolved
@TMisiukiewicz TMisiukiewicz force-pushed the feat/opt-in-pod-install branch from 462ac6a to 98991d2 Compare October 23, 2023 07:32
packages/cli/src/commands/init/init.ts Outdated Show resolved Hide resolved
packages/cli/src/commands/init/init.ts Outdated Show resolved Hide resolved
@TMisiukiewicz TMisiukiewicz force-pushed the feat/opt-in-pod-install branch from 98991d2 to 7c0fc7d Compare October 23, 2023 12:30
docs/projects.md Outdated Show resolved Hide resolved
@TMisiukiewicz TMisiukiewicz force-pushed the feat/opt-in-pod-install branch from 0fd861d to 7c163ff Compare October 30, 2023 14:06
@TMisiukiewicz TMisiukiewicz force-pushed the feat/opt-in-pod-install branch from 57a47c3 to 453b07d Compare October 31, 2023 11:21
@TMisiukiewicz TMisiukiewicz force-pushed the feat/opt-in-pod-install branch from 453b07d to 3f1ffcf Compare October 31, 2023 14:51
@TMisiukiewicz TMisiukiewicz merged commit 9c52009 into react-native-community:main Oct 31, 2023
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation change feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants