-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: opt-in pod install with ios commands #2116
Merged
TMisiukiewicz
merged 10 commits into
react-native-community:main
from
TMisiukiewicz:feat/opt-in-pod-install
Oct 31, 2023
Merged
feat: opt-in pod install with ios commands #2116
TMisiukiewicz
merged 10 commits into
react-native-community:main
from
TMisiukiewicz:feat/opt-in-pod-install
Oct 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tido64
reviewed
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this ❤️
This was referenced Oct 13, 2023
TMisiukiewicz
force-pushed
the
feat/opt-in-pod-install
branch
from
October 16, 2023 07:43
9865045
to
d2336a8
Compare
tido64
approved these changes
Oct 16, 2023
thymikee
reviewed
Oct 19, 2023
TMisiukiewicz
force-pushed
the
feat/opt-in-pod-install
branch
from
October 23, 2023 07:32
462ac6a
to
98991d2
Compare
tido64
reviewed
Oct 23, 2023
TMisiukiewicz
force-pushed
the
feat/opt-in-pod-install
branch
from
October 23, 2023 12:30
98991d2
to
7c0fc7d
Compare
adamTrz
approved these changes
Oct 24, 2023
thymikee
reviewed
Oct 30, 2023
thymikee
reviewed
Oct 30, 2023
TMisiukiewicz
force-pushed
the
feat/opt-in-pod-install
branch
from
October 30, 2023 14:06
0fd861d
to
7c163ff
Compare
thymikee
approved these changes
Oct 30, 2023
TMisiukiewicz
force-pushed
the
feat/opt-in-pod-install
branch
from
October 31, 2023 11:21
57a47c3
to
453b07d
Compare
TMisiukiewicz
force-pushed
the
feat/opt-in-pod-install
branch
from
October 31, 2023 14:51
453b07d
to
3f1ffcf
Compare
TMisiukiewicz
merged commit Oct 31, 2023
9c52009
into
react-native-community:main
3 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adding new config parameter
project.ios.automaticPodsInstallation
.For existing apps, it means developers can opt-in for automatic CocoaPods installation when running
run-ios
orbuild-ios
. Some projects are running on non-standard setups or pods installation is simply not desired.For the users using
init
command starting from 0.73, it will automatically create thereact-native.config.js
file with this param set totrue
. File is created by CLI after processing the template.Test Plan:
npx react-native init
run-ios
and make sure CocoaPods step is skippedreact-native.config.js
file and setproject.ios.automaticPodsInstallation
totrue
run-ios
again and confirm that CocoaPods are getting installednode ./path/to/cli init
n
react-native.config.js
file existsrun-ios
and verify pods are getting installedChecklist