Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Changing node version missed during metro dependencies upgrade #2015

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

arushikesarwani94
Copy link
Contributor

Summary:

Updating the node version missed in #2007 as 18 is the Current version, will be LTS in October.

Test Plan:

Tests pass

Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thymikee
Copy link
Member

Install fails on node 20. I actually had the same locally and went back to 18 as I didn't have time to investigate

@szymonrybczak
Copy link
Collaborator

szymonrybczak commented Jul 12, 2023

I think this is problem related to node-gyp, as we're on old version -node-gyp is one of dependencies that comes with lerna. I bumped leran locally from 4.0.0 to 5.0.0 and the project is building for me correctly.

Edit: PR updating lerna #2017

@szymonrybczak
Copy link
Collaborator

@arushikesarwani94 mind rebasing on top of main?

@szymonrybczak
Copy link
Collaborator

Hm, looks like CI is failing on creating project on node 20 on Ubuntu, interesting. 🤔

@arushikesarwani94
Copy link
Contributor Author

Hm, looks like CI is failing on creating project on node 20 on Ubuntu, interesting. 🤔

Not sure why this would just fail on Ubuntu for Node 20.

cc: @thymikee Any idea what could be going on ?

@thymikee thymikee merged commit 3a26528 into react-native-community:main Nov 2, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants