♻️ refactor: improve logic#622
Merged
zombieJ merged 3 commits intoreact-component:masterfrom Feb 7, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
""" Walkthrough此更改调整了 Changes
Sequence Diagram(s)sequenceDiagram
participant C as 调用者
participant F as findExistNode
participant S as findStyles
C->>F: 调用 findExistNode(option, key)
F->>F: 检查 styles 是否已定义
alt styles 未定义或为 null
F->>S: 调用 findStyles(getContainer(option))
S-->>F: 返回样式集合
end
F->>F: 在 styles 中查找指定 key 的节点
F-->>C: 返回匹配节点或 null
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #622 +/- ##
=======================================
Coverage 90.01% 90.01%
=======================================
Files 36 36
Lines 881 881
Branches 297 290 -7
=======================================
Hits 793 793
Misses 86 86
Partials 2 2 ☔ View full report in Codecov by Sentry. |
zombieJ
reviewed
Feb 7, 2025
| }, | ||
| "devDependencies": { | ||
| "@rc-component/father-plugin": "^2.0.1", | ||
| "@rc-component/np": "^1.0.3", |
Member
There was a problem hiding this comment.
prepublishOnly 里要把 np 改成 rc-np，然后去掉参数
zombieJ
approved these changes
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
浅改一下逻辑, 少走一部分计算
Summary by CodeRabbit
"@rc-component/np": "^1.0.3"。"np": "^10.0.2"。