-
-
Notifications
You must be signed in to change notification settings - Fork 194
feat(a11y): add screen reader support for Tooltip #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+80
−6
Merged
Changes from 15 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
5489369
feat(a11y): add screen reader support for Tooltip
aojunhao123 241527e
fix: lint fix
aojunhao123 3f2bea8
chore: remove unnecessary jest config file
aojunhao123 dbe400e
fix: ensure getTextContent returns an empty string for invalid nodes …
aojunhao123 4b09132
chore: clean code
aojunhao123 f645402
chore: clean code
aojunhao123 36ec1b8
chore: clean code
aojunhao123 6e13e74
refactor(Tooltip): simplify ID handling by merging useId with props
aojunhao123 c6e9666
chore: adjust logic
aojunhao123 5141249
fix: lint fix
aojunhao123 037f5b1
chore: revert some changes
aojunhao123 7c36d0d
fix(Tooltip): handle invalid children by wrapping them in a span element
aojunhao123 f45efa7
chore: clean code
aojunhao123 34a03a0
chore: clean code
aojunhao123 a378f1a
fix: lint fic
aojunhao123 7a222c3
fix: lint revert
aojunhao123 ae4519f
test: add test case
aojunhao123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.