generated from react-component/footer
-
-
Notifications
You must be signed in to change notification settings - Fork 325
fix: presets和maxDate的对比 #930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Roxannej
wants to merge
18
commits into
react-component:master
Choose a base branch
from
Roxannej:fix-disabled
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
1e172c4
fix: presets和maxDate的对比
Roxannej ac97da7
Merge branch 'master' into fix-disabled
Roxannej 8ea1389
fix: presets和maxDate的对比
Roxannej 74137d8
fix: presets和maxDate的对比
Roxannej 14591ab
fix: presets和maxDate的对比
Roxannej 65e65df
fix: presets和maxDate的对比
Roxannej dac6b70
fix: presets和maxDate的对比
Roxannej 193a8a0
fix: presets和maxDate的对比
Roxannej 9433f3d
fix: presets和maxDate的对比
Roxannej fbfa751
fix: presets和maxDate的对比
Roxannej 68aaf81
fix: presets和maxDate的对比
Roxannej 7fc89fe
fix: presets和maxDate
Roxannej 8e29e88
Merge branch 'fix-disabled' of github.com:Roxannej/picker into fix-di…
Roxannej 7ba2b3d
fix: preset 和maxDate
Roxannej 5618439
fix: presets和maxDate对比
Roxannej f4e2ad8
fix: preset和maxDate
Roxannej 3a76aa6
fix: presets和maxDate对比
Roxannej 201eb0b
fix: presets和maxDate的大小比较
Roxannej File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
需要 generateConfig 进行日期比较
为了与项目其他部分保持一致并支持不同的日期库,建议通过 props 传入
generateConfig
。还需要在调用此组件的地方传入
generateConfig
。🏁 Script executed:
Length of output: 33299
🏁 Script executed:
Length of output: 1930
需要为 PresetPanel 添加 generateConfig 支持,移除对 moment 的直接依赖
为了与项目其他地方保持一致并支持多种日期库,建议对
src/PickerInput/Popup/PresetPanel.tsx
做以下修改:• 在 Props 接口中:
maxDate?: dateTy;
为maxDate?: ValueType;
generateConfig: GenerateConfig<ValueType>;
• 在组件签名和解构 props 时引入
generateConfig
• 将
替换为
• 在调用此组件的地方(如
PopupPanel.tsx
)传入generateConfig
示例 diff:
请同时在使用
<PresetPanel>
的所有调用处(如 PopupPanel)传入当前的generateConfig
。🤖 Prompt for AI Agents