Skip to content

Comments

fix(onChange): specify event may triggered with null#380

Closed
chalkpe wants to merge 1 commit intoreact-component:masterfrom
chalkpe:patch-1
Closed

fix(onChange): specify event may triggered with null#380
chalkpe wants to merge 1 commit intoreact-component:masterfrom
chalkpe:patch-1

Conversation

@chalkpe
Copy link

@chalkpe chalkpe commented Nov 19, 2021

onChange is triggered with null sometimes, but type of value is just ValueType (string | number) for now.
However making this change is likely going to be a breaking change; it's more confusing null is given without any notice.

references

...
expect(onChange).toHaveBeenCalledWith(null);
...

@vercel
Copy link

vercel bot commented Nov 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/input-number/3npR9wzGX31HJtD9rgMbaxWaQsAE
✅ Preview: Failed

@chalkpe chalkpe closed this Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants