Conversation
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
==========================================
+ Coverage 98.57% 98.70% +0.12%
==========================================
Files 2 2
Lines 70 77 +7
Branches 24 24
==========================================
+ Hits 69 76 +7
Misses 1 1
Continue to review full report at Codecov.
|
Member
|
https://github.com/ant-design/ant-design/runs/691739740 https://github.com/ant-design/ant-design/suites/698853523/artifacts/6703648 lighthourse 里针对 a11y 也有很多扣分项，可以一并解决一下。
|
Member
|
冲突了 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
看了一下，当年 Menu 基于 Lighthouse 打分做了一下 aria 标签，但是并没有真的连起来。找个时间两个组件一同整理一下。
ref react-component/menu#137