Skip to content

Add support for hash prop #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2015
Merged

Add support for hash prop #128

merged 1 commit into from
Oct 19, 2015
+94 −113

Conversation

taion
Copy link
Member

@taion taion commented Oct 18, 2015

No description provided.

@taion
Copy link
Member Author

taion commented Oct 18, 2015

There's really 3 things going on here:

  • Add support for the hash prop on LinkContainer to match upstream Link
  • Switch tests to click on the anchor element now that NavItem is fixed to put onClick on the <a>
  • Switch tests to use stateless components to be a bit less verbose

@taion
[added] Support hash prop on LinkContainer
5ca61cf 
Also update dependencies appropriately
@taion taion mentioned this pull request Oct 18, 2015
Merged
@AlexKVal
Copy link
Member

I see. This PR reflects recents changes in R-B.
LGTM

AlexKVal added a commit that referenced this pull request Oct 19, 2015
@AlexKVal
Merge pull request #128 from taion/link-hash
e03139e 
Add support for hash prop
@AlexKVal AlexKVal merged commit e03139e into react-bootstrap:master Oct 19, 2015
@AlexKVal AlexKVal mentioned this pull request Oct 19, 2015
Closed
@taion taion deleted the link-hash branch October 28, 2015 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@taion @AlexKVal