Skip to content

fix: support helper and error text outside inset lists - #32

Merged
rdlabo merged 1 commit into
mainfrom
fix/support-text-outside-inset-lists
Aug 27, 2026
Merged

fix: support helper and error text outside inset lists#32
rdlabo merged 1 commit into
mainfrom
fix/support-text-outside-inset-lists

Conversation

@rdlabo

@rdlabo rdlabo commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • extract support-text handling from the inset-only layout mixin
  • apply it to every ion-item inside themed ion-list elements
  • preserve existing inset-list surface and nested-group styling

This lets input, textarea, and select helper/error areas render correctly in both inset and non-inset lists, including items under reorder, accordion, and radio groups.

Verification

  • npm run build
  • Prettier check for the changed SCSS files
  • git diff --check
  • inspected generated CSS selectors for the non-inset list scope

@github-actions

Copy link
Copy Markdown
Contributor

Playwright test results

passed  78 passed

Details

stats  78 tests across 1 suite
duration  1 minute, 34 seconds
commit  f107343
info  This detailed result covers Ionic 9 only. Ionic 8 runs against the same screenshots in a separate matrix job; check the workflow run for both results. To update the screenshots, comment with /update-screenshots.

@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-md3/pr-32/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Aug 27, 2026
@rdlabo
rdlabo merged commit 29beb66 into main Aug 27, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant