Skip to content

RDKEMW-15306: Observing ERROR log line "firmware upgrade FAILED with error <Device disconnected>" during successful OTA #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
msmith113 wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

RDKEMW-15306: Observing ERROR log line "firmware upgrade FAILED with error <Device disconnected>" during successful OTA #280

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
167424b
RDKEMW-15306: Observing ERROR log line "firmware upgrade FAILED with …
msmith113 Sep 1, 2026
56a6108
Reverting fix to test first
msmith113 Sep 1, 2026
99765e1
Added back the fix
msmith113 Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/ble/hal/blercu/bleservices/gatt/gatt_upgradeservice.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1001,8 +1001,17 @@ void GattUpgradeService::onACKPacket(const vector<uint8_t> &data)

const int fwDataSize = static_cast<int>(m_fwFile->size());

// check if the ACK is for the last block
if ((blockId * FIRMWARE_PACKET_MTU) > fwDataSize) {
// TEMP DIAGNOSTIC (RDKEMW-15306): confirm last-block detection over the final
// couple of windows (only log near the end to keep the log readable)
if ((blockId + 2 * m_windowSize) * FIRMWARE_PACKET_MTU >= fwDataSize) {
XLOGD_INFO("ACK diag: blockId=%d, blockId*MTU=%d, fwDataSize=%d, fwDataSize%%MTU=%d, lastBlock=%s",
blockId, (blockId * FIRMWARE_PACKET_MTU), fwDataSize, (fwDataSize % FIRMWARE_PACKET_MTU),
((blockId * FIRMWARE_PACKET_MTU) >= fwDataSize) ? "TRUE" : "FALSE");
}

// check if the ACK is for the last block (>= so an image sized an exact
// multiple of FIRMWARE_PACKET_MTU also completes on its final block's ACK)
if ((blockId * FIRMWARE_PACKET_MTU) >= fwDataSize) {

// stop the timeout
if (m_timeoutTimer > 0) {
Expand Down
Loading