RDKEMW-18167: ctrlm cleanup warnings during ci build - #278
Open
msmith113 wants to merge 6 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the CI coverage build script for the ctrlm-main plugin to stop suppressing -Werror, aligning CI builds with the project’s CMake configuration that enables -Werror via target_compile_options.
Changes:
- Remove
-Wno-errorfromCMAKE_CXX_FLAGSandCMAKE_C_FLAGSpassed to CMake inci/cov_build.sh. - Remove the post-configure
find ... sed ...step that previously stripped-Werrorfrom generated Ninja/Make flags files.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Suppressed comments (1)
ci/build_dependencies.sh:74
- The dependency fetch is hard-pinned to a feature branch (
feature/RDKEMW-18167). CI becomes non-reproducible and can break if the branch is force-pushed or deleted; it would be safer to pin to a commit SHA (or at least make the ref configurable and document why it’s notdevelop).
git clone --depth 1 --filter=blob:none --sparse --branch feature/RDKEMW-18167 https://github.com/rdkcentral/meta-rdk-oss-reference.git
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
ci/build_dependencies.sh:74
- The CI dependency clone is now pinned to a mutable feature branch (
feature/RDKEMW-18167) inmeta-rdk-oss-reference. This can make CI non-reproducible and fragile if the branch is rebased or deleted; consider pinning to an immutable tag/commit SHA (or at least making the ref an explicit, centrally-managed variable) so builds remain deterministic.
git clone --depth 1 --filter=blob:none --sparse --branch feature/RDKEMW-18167 https://github.com/rdkcentral/meta-rdk-oss-reference.git
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://ccp.sys.comcast.net/browse/RDKEMW-18167