RDKEMW-14903: MFV Device Support in Control Manager - #244
Open
msmith113 wants to merge 89 commits into
Open
Conversation
msmith113
force-pushed
the
feature/RDKEMW-14903
branch
from
June 23, 2026 15:27
02c91ba to
7dbebb5
Compare
msmith113
commented
Jun 26, 2026
dwolaver
reviewed
Jun 26, 2026
dwolaver
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Just a couple of comments...
There was a problem hiding this comment.
Pull request overview
Adds MFV (Mid-Field Voice) device support to the Control Manager BLE stack by extending the BLE RDK Voice (audio) service to discover/read MFV characteristics, emit MFV status updates into the HAL status pipeline, and optionally trigger voice sessions on MFV detections (including a config-controlled path for “below-threshold” detections).
Changes:
- Added MFV GATT UUIDs and MFV characteristic discovery/reads/notifications to the RDK audio service implementation.
- Extended BLE HAL/property plumbing to surface MFV detection type/data, privacy, and capabilities; and to trigger voice sessions from MFV detection notifications.
- Added a new BLE network config option to enable starting sessions from below-threshold MFV detections.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ctrlm_config_default.json | Adds default config flag for below-threshold MFV session behavior. |
| src/ble/hal/utils/bleuuid.h | Adds MFV-related characteristic UUID enum entries. |
| src/ble/hal/utils/bleuuid.cpp | Registers human-readable names for the new MFV UUIDs. |
| src/ble/hal/blercu/bluez/blercudevice.cpp | Includes the audio service header to support MFV/audio service integration. |
| src/ble/hal/blercu/bleservices/gatt/gatt_audioservice_rdk.h | Adds MFV API overrides, characteristic handles, and MFV state storage. |
| src/ble/hal/blercu/bleservices/gatt/gatt_audioservice_rdk.cpp | Implements MFV discovery, initial reads, notifications, and MFV write operations. |
| src/ble/hal/blercu/bleservices/blercuaudioservice.h | Introduces MFV types, accessors, and signals on the audio service interface. |
| src/ble/ctrlm_ble_rcu_interface.cpp | Plumbs MFV audio-service signals into HAL RCU status updates; includes MFV in full property snapshot. |
| src/ble/ctrlm_ble_network.h | Adds network member to store below-threshold MFV session enable flag. |
| src/ble/ctrlm_ble_network.cpp | Reads MFV config flag; reacts to MFV status updates and starts voice sessions based on detection type. |
| src/ble/ctrlm_ble_controller.h | Adds MFV state fields and accessors on BLE controller object. |
| src/ble/ctrlm_ble_controller.cpp | Implements MFV getters/setters and prints MFV status in controller status output. |
| include/ctrlm_hal_ble.h | Extends HAL enums/properties/structs to represent MFV detection/data/privacy/capabilities. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…keyword verification true for MFV wuw session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://ccp.sys.comcast.net/browse/RDKEMW-14903