Skip to content

RDKEMW-14903: MFV Device Support in Control Manager - #244

Open
msmith113 wants to merge 89 commits into
developfrom
feature/RDKEMW-14903
Open

RDKEMW-14903: MFV Device Support in Control Manager#244
msmith113 wants to merge 89 commits into
developfrom
feature/RDKEMW-14903

Conversation

@msmith113

@msmith113 msmith113 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

@msmith113
msmith113 force-pushed the feature/RDKEMW-14903 branch from 02c91ba to 7dbebb5 Compare June 23, 2026 15:27
Comment thread src/ble/ctrlm_ble_network.cpp Outdated

@dwolaver dwolaver left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a couple of comments...

Comment thread include/ctrlm_hal_ble.h Outdated
Comment thread src/ble/ctrlm_ble_network.cpp Outdated
@msmith113
msmith113 marked this pull request as ready for review June 30, 2026 15:46
@msmith113
msmith113 requested a review from a team as a code owner June 30, 2026 15:46
Copilot AI lite review requested due to automatic review settings June 30, 2026 15:46

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds MFV (Mid-Field Voice) device support to the Control Manager BLE stack by extending the BLE RDK Voice (audio) service to discover/read MFV characteristics, emit MFV status updates into the HAL status pipeline, and optionally trigger voice sessions on MFV detections (including a config-controlled path for “below-threshold” detections).

Changes:

  • Added MFV GATT UUIDs and MFV characteristic discovery/reads/notifications to the RDK audio service implementation.
  • Extended BLE HAL/property plumbing to surface MFV detection type/data, privacy, and capabilities; and to trigger voice sessions from MFV detection notifications.
  • Added a new BLE network config option to enable starting sessions from below-threshold MFV detections.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/ctrlm_config_default.json Adds default config flag for below-threshold MFV session behavior.
src/ble/hal/utils/bleuuid.h Adds MFV-related characteristic UUID enum entries.
src/ble/hal/utils/bleuuid.cpp Registers human-readable names for the new MFV UUIDs.
src/ble/hal/blercu/bluez/blercudevice.cpp Includes the audio service header to support MFV/audio service integration.
src/ble/hal/blercu/bleservices/gatt/gatt_audioservice_rdk.h Adds MFV API overrides, characteristic handles, and MFV state storage.
src/ble/hal/blercu/bleservices/gatt/gatt_audioservice_rdk.cpp Implements MFV discovery, initial reads, notifications, and MFV write operations.
src/ble/hal/blercu/bleservices/blercuaudioservice.h Introduces MFV types, accessors, and signals on the audio service interface.
src/ble/ctrlm_ble_rcu_interface.cpp Plumbs MFV audio-service signals into HAL RCU status updates; includes MFV in full property snapshot.
src/ble/ctrlm_ble_network.h Adds network member to store below-threshold MFV session enable flag.
src/ble/ctrlm_ble_network.cpp Reads MFV config flag; reacts to MFV status updates and starts voice sessions based on detection type.
src/ble/ctrlm_ble_controller.h Adds MFV state fields and accessors on BLE controller object.
src/ble/ctrlm_ble_controller.cpp Implements MFV getters/setters and prints MFV status in controller status output.
include/ctrlm_hal_ble.h Extends HAL enums/properties/structs to represent MFV detection/data/privacy/capabilities.

Comment thread src/ble/hal/blercu/bleservices/gatt/gatt_audioservice_rdk.cpp Outdated
Comment thread src/ble/hal/blercu/bleservices/gatt/gatt_audioservice_rdk.cpp Outdated
Comment thread src/ble/hal/blercu/bleservices/blercuaudioservice.h
Comment thread src/ble/hal/blercu/bleservices/blercuaudioservice.h
Comment thread include/ctrlm_hal_ble.h
Comment thread src/ble/hal/blercu/bleservices/gatt/gatt_audioservice_rdk.h Outdated
Copilot AI review requested due to automatic review settings July 9, 2026 12:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 10 comments.

Comment thread include/ctrlm_hal_ble.h Outdated
Comment thread src/ble/hal/blercu/bleservices/gatt/gatt_audioservice_rdk.cpp Outdated
Comment thread src/ble/hal/blercu/bleservices/gatt/gatt_audioservice_rdk.cpp Outdated
Comment thread src/ble/hal/blercu/bleservices/blercuaudioservice.h
Comment thread src/ble/hal/blercu/bleservices/blercuaudioservice.h Outdated
Comment thread src/ble/hal/blercu/bleservices/gatt/gatt_audioservice_rdk.h Outdated
Comment thread src/ble/ctrlm_ble_network.cpp Outdated
Comment thread src/ble/ctrlm_ble_network.cpp Outdated
Comment thread src/ble/ctrlm_ble_controller.cpp Outdated
Comment thread src/ble/ctrlm_ble_controller.cpp Outdated
Copilot AI review requested due to automatic review settings July 9, 2026 12:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.

Comment thread include/ctrlm_hal_ble.h Outdated
Comment thread src/ble/hal/blercu/bleservices/blercuaudioservice.h
Comment thread src/ble/hal/blercu/bleservices/blercuaudioservice.h Outdated
Comment thread src/ble/hal/blercu/bleservices/gatt/gatt_audioservice_rdk.cpp
Copilot AI review requested due to automatic review settings July 9, 2026 12:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.

Comment thread include/ctrlm_hal_ble.h
Comment thread src/ble/hal/blercu/bluez/blercudevice.cpp Outdated
Comment thread src/ble/hal/blercu/bleservices/gatt/gatt_audioservice_rdk.cpp
Comment thread src/ble/hal/blercu/bleservices/gatt/gatt_audioservice_rdk.cpp Outdated
Comment thread src/ble/hal/blercu/bleservices/gatt/gatt_audioservice_rdk.cpp Outdated
Copilot AI review requested due to automatic review settings July 9, 2026 12:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Comment thread include/ctrlm_hal_ble.h Outdated
Comment thread include/ctrlm_hal_ble.h Outdated
Copilot AI review requested due to automatic review settings July 9, 2026 13:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Comment thread include/ctrlm_hal_ble.h Outdated
Comment thread include/ctrlm_hal_ble.h Outdated
Comment thread src/ble/hal/blercu/bleservices/gatt/gatt_audioservice_rdk.cpp
Copilot AI review requested due to automatic review settings July 9, 2026 13:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Comment thread include/ctrlm_hal_ble.h
Comment thread include/ctrlm_hal_ble.h Outdated
Copilot AI review requested due to automatic review settings July 9, 2026 13:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Comment thread src/ble/hal/blercu/bleservices/gatt/gatt_audioservice_rdk.cpp Outdated
Comment thread src/ble/hal/blercu/bleservices/gatt/gatt_audioservice_rdk.cpp Outdated
Comment thread src/ble/hal/blercu/bleservices/blercuaudioservice.h
Copilot AI review requested due to automatic review settings July 9, 2026 14:07
msmith113 and others added 30 commits August 27, 2026 20:35
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…keyword verification true for MFV wuw session
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants