Example and QA interfaces section added for Windows - #504
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Visual Studio project support for building the example_interfaces and qa_interfaces ProxyStub libraries on Windows (to complement the existing Windows project files in this repo and the dependency noted in ThunderOnWindows#17).
Changes:
- Added
ExampleInterfaces.vcxproj+.filtersfor Windows builds ofexample_interfaces. - Added
QAInterfaces.vcxproj+.filtersfor Windows builds ofqa_interfaces. - Wired both projects to run
StubGenerator.pyas a pre-build step and output artifacts underartifacts\ProxyStubs.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| qa_interfaces/QAInterfaces.vcxproj.filters | Adds Solution Explorer filters for QA interface sources/headers and generated stubs. |
| qa_interfaces/QAInterfaces.vcxproj | Adds the Windows project for building QA ProxyStubs with a pre-build stub generation step. |
| example_interfaces/ExampleInterfaces.vcxproj.filters | Adds Solution Explorer filters for example interface sources/headers and generated stubs. |
| example_interfaces/ExampleInterfaces.vcxproj | Adds the Windows project for building example ProxyStubs with a pre-build stub generation step. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sebaszm
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requires this:
WebPlatformForEmbedded/ThunderOnWindows#17