Skip to content

Fixes Claude-identified bugs/typos - #127

Merged
brgix merged 1 commit into
developfrom
v361
Aug 27, 2026
Merged

Fixes Claude-identified bugs/typos#127
brgix merged 1 commit into
developfrom
v361

Conversation

@brgix

@brgix brgix commented Aug 27, 2026

Copy link
Copy Markdown
Member

Using Claude, CanmetEnergy has recently generated a Python version of TBD (py-tbd).

In the process, a number of bugs (mainly typos) have been identified in the original TBD Ruby gem.

Fixing ...

@brgix brgix self-assigned this Aug 27, 2026
@brgix brgix added the bug Something isn't working label Aug 27, 2026
@brgix brgix linked an issue Aug 27, 2026 that may be closed by this pull request
Comment thread lib/tbd/ua.rb
model += " (v#{ua[:version]})" if ua.key?(:version)
report << model unless model.empty?
report << "* TBD : v3.6.0"
report << "* TBD : v3.6.1"

@brgix brgix Aug 27, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug description from Claude:

ua_md hard-codes "* TBD : v3.6.0" while ua_summary uses the passed-in SDK :version; two independent version sources.

Claude appears to be confounding:

  • the TBD gem version (now v3.6.1)
  • the OpenStudio SDK/CLI version

... they're totally unrelated.

@brgix

brgix commented Aug 27, 2026

Copy link
Copy Markdown
Member Author

Apart from the TBD vs SDK version confusion, Claude did a great job at identifying a dozen or so bugs. These were mostly typos and/or the fruit of inconsistent copy/paste operations at the time (e.g. when extending the list of admissible edge types). Although they definitely needed fixing, TBD had enough safeguards and fallbacks to avoid potential crashes stemming from these typos. Yet glad to have fixed them, as they would have yielded incorrect values in rare cases.

Thanks to @phylroy at CanmetEnergy!

All tests are green (including these).

@brgix
brgix merged commit 88bd0ae into develop Aug 27, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Canmet/Ai-identified bugs/typos

1 participant