removing init and keeping it in bootstrap

razorpay · Mar 12, 2024 · bd6db87 · bd6db87
1 parent 8656033
commit bd6db87
Showing 1 changed file with 0 additions and 13 deletions.
diff --git a/sql-delta-import/src/main/scala/com/razorpay/spark/jdbc/JDBCImport.scala b/sql-delta-import/src/main/scala/com/razorpay/spark/jdbc/JDBCImport.scala
@@ -50,7 +50,6 @@ case class ImportConfig(
 
   val splitColumn: String = splitBy.getOrElse(null.asInstanceOf[String])
 
-  credentials.init()
   val dbType: String = credentials.getSecretValue("datum/datahub/MYSQL_SQOOP_PROD_DATUM_MYSQL_TYPE", "credstash-stage-datahub")
 
   val escapeCharacter = if (dbType == Constants.MYSQL) {
@@ -85,7 +84,6 @@ class JDBCImport(
   import spark.implicits._
 
   def createDbIfNotExists(outputDbName: String): Unit = {
-    credentials.init()
     val s3Bucket = credentials.getSecretValue("datum/datahub/SQOOP_S3_BUCKET", "credstash-stage-datahub")
     val baseS3Path = s"s3a://$s3Bucket/sqoop"
 
@@ -98,7 +96,6 @@ class JDBCImport(
 
   implicit def mapToProperties(m: Map[String, String]): Properties = {
     val properties = new Properties()
-    credentials.init()
     val jdbcUsername = credentials.getSecretValue("datum/datahub/MYSQL_SQOOP_PROD_DATUM_MYSQL_USER", "credstash-stage-datahub")
     val jdbcPassword = credentials.getSecretValue("datum/datahub/MYSQL_SQOOP_PROD_DATUM_MYSQL_PASSWORD", "credstash-stage-datahub")
 
@@ -127,7 +124,6 @@ class JDBCImport(
   }
 
   def buildJdbcUrl: String = {
-    credentials.init()
     val host = credentials.getSecretValue("datum/datahub/MYSQL_SQOOP_PROD_DATUM_MYSQL_HOST", "credstash-stage-datahub")
     val port = credentials.getSecretValue("datum/datahub/MYSQL_SQOOP_PROD_DATUM_MYSQL_PORT", "credstash-stage-datahub")
     val dbType = credentials.getSecretValue("datum/datahub/MYSQL_SQOOP_PROD_DATUM_MYSQL_TYPE", "credstash-stage-datahub")
@@ -163,7 +159,6 @@ class JDBCImport(
         .map { case (a, b) => (a.getOrElse(defaultString), b.getOrElse(defaultString)) }
         .head
 
-      credentials.init()
       val jdbcUsername = credentials.getSecretValue("datum/datahub/MYSQL_SQOOP_PROD_DATUM_MYSQL_USER", "credstash-stage-datahub")
       val jdbcPassword = credentials.getSecretValue("datum/datahub/MYSQL_SQOOP_PROD_DATUM_MYSQL_PASSWORD", "credstash-stage-datahub")
 
@@ -293,7 +288,6 @@ class JDBCImport(
 
     val s3BucketConf = importConfig.s3Bucket
 
-    credentials.init()
     val s3Bucket = if (s3BucketConf.isDefined) { s3BucketConf.get }
     else { credentials.getSecretValue("datum/datahub/SQOOP_S3_BUCKET", "credstash-stage-datahub") }
 
@@ -340,13 +334,6 @@ object JDBCImport {
 }
 
 object credentials {
-  def init(): Unit = {
-    "echo \"Installing python dependencies\"".!!
-    "sudo python3 -m pip install credstash".!!
-    "sudo curl -sL https://github.com/Versent/unicreds/releases/download/1.7.0/unicreds_1.7.0_linux_amd64.tar.gz --output /tmp/unicreds_1.7.0_linux_amd64.tar.gz".!!
-    "sudo tar -zxf /tmp/unicreds_1.7.0_linux_amd64.tar.gz -C /usr/local/bin/".!!
-    "sudo chmod +x /usr/local/bin/unicreds".!!
-  }
   def getSecretValue(secretName: String, table_name: String): String = {
     val key : String =
       s"credstash -t $table_name -r ap-south-1 get $secretName".!!.trim