Skip to content

fix: audit actor name column width #1319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohanchkrabrty merged 3 commits into from
Dec 9, 2025
Merged

fix: audit actor name column width #1319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
811ad05
fix: admin actor name
rohanchkrabrty Dec 8, 2025
5af3017
fix: admin audit actor name
rohanchkrabrty Dec 8, 2025
1f433aa
feat: admin audit actor name truncate
rohanchkrabrty Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ui/src/pages/audit-logs/list/actor-cell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,15 @@ import KeyIcon from "~/assets/icons/key.svg?react";
type ActorCellProps = {
size?: "large" | "small";
value: AuditRecordActor;
maxLength?: number;
};

export default function ActorCell({ size = "large", value }: ActorCellProps) {
const name = getAuditLogActorName(value);
export default function ActorCell({
size = "large",
value,
maxLength,
}: ActorCellProps) {
const name = getAuditLogActorName(value, maxLength);
const isSystem = value.type === ACTOR_TYPES.SYSTEM;
const isServiceUser = value.type === ACTOR_TYPES.SERVICE_USER;

Expand Down
2 changes: 1 addition & 1 deletion ui/src/pages/audit-logs/list/list.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@

.name-column {
padding-left: var(--rs-space-7);
max-width: 200px;
max-width: 240px;
}
.org-column {
max-width: 200px;
Expand Down
2 changes: 1 addition & 1 deletion ui/src/pages/audit-logs/list/sidepanel-details.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export default function SidePanelDetails({
href={`/users/${actor?.id}`}
label="Actor"
data-test-id="actor-link">
<ActorCell value={actor!} size="small" />
<ActorCell value={actor!} size="small" maxLength={12} />
</SidepanelListItemLink>
<SidepanelListItemLink
isLink={!!orgId && !isZeroUUID(orgId)}
Expand Down
10 changes: 8 additions & 2 deletions ui/src/pages/audit-logs/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,18 @@ import {
AuditRecordSchema,
} from "@raystack/proton/frontier";

export const getAuditLogActorName = (actor?: AuditRecordActor) => {
export const getAuditLogActorName = (
actor?: AuditRecordActor,
maxLength = 15,
) => {
if (actor?.type === ACTOR_TYPES.SYSTEM) return "System";

const name = actor?.title || actor?.name || "-";

if (actor?.metadata?.["is_super_user"] === true) return name + " (Admin)";
if (actor?.metadata?.["is_super_user"] === true)
if (name.length > maxLength)
return name.substring(0, maxLength) + "..." + " (Admin)";
else return name + " (Admin)";

return name;
};
Expand Down
Loading