feat: migrate Admin RPCs to connectRPC server #1119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
whoAbhishekSah
force-pushed
the
connectrpc_admin_mixed_rpc
branch
from
67f857f to
2df72c0
Compare
Pull Request Test Coverage Report for Build 17424751591Details
💛 - Coveralls |
whoAbhishekSah
force-pushed
the
connectrpc_admin_mixed_rpc
branch
from
9158032 to
eb28ca2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate Admin RPCs to ConnectRPC server
The following RPCs are migrated.
The implementation of the handlers is similar to that of the gRPC handlers.
I have just made it compatible with the ConnectRPC signature.
We have used connect errors instead of gRPC errors.