-
Notifications
You must be signed in to change notification settings - Fork 13
feat (Navbar): add Navbar.center, shadow prop, hideOnScroll Prop, etc. #658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
paanSinghCoder
wants to merge
12
commits into
main
Choose a base branch
from
feat/navbar-improvements-center
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,831
−2,279
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7443d0f
feat: add center and add shadow prop
paanSinghCoder 7809f71
feat: add hideOnScroll, flex props
paanSinghCoder 8fa1c84
docs: update Navbar documentation to include Flex props and new hideO…
paanSinghCoder df4e7bd
refactor: remove outdated comment from NavbarRootProps interface
paanSinghCoder ef62db5
refactor: update Navbar demo sections for clarity and consistency
paanSinghCoder 4f02ce1
feat: enhance DemoPreview component with customizable preview class
paanSinghCoder 8e799ae
feat: enhance Navbar demo with shadow prop and updated styles
paanSinghCoder 33859b9
feat: add hideOnScroll demo to Navbar documentation
paanSinghCoder 7500a58
docs: clarify navbar hideOnScroll behavior in documentation
paanSinghCoder 2602aca
chore: add Navbar into examples page
paanSinghCoder dcafa37
feat: refactor Navbar layout to use grid system and absolute center t…
paanSinghCoder 64381d7
feat: enhance NavbarRoot component with scroll behavior improvements
paanSinghCoder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not add
previewClassNamehere to handle one off cases. It's better to use a container in demo.ts examples to achieve this.It will by default show dotted content area irrespective of the component rendered.