Avoid overrunning the 256 icon memory buffer #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raysan5
reviewed
Jul 30, 2025
|
|
||
| // NOTE: A pointer to current icons array should be defined | ||
| static unsigned int *guiIconsPtr = guiIcons; | ||
| static int guiIconsCount = RAYGUI_ICON_MAX_ICONS; |
Owner
There was a problem hiding this comment.
I'd prefer to avoid an additional global variable for it, could we just check for RAYGUI_ICON_MAX_ICONS?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid overrunning the end of the icon buffer (default 256 size) when printing labels with Icons.
Previously, if the user entered a value >255 (e.g. "#999#") the program would read invalid memory (causing a crash with ASAN enabled).