-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[reefd] add windows instance reaper #261
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| package reefd | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| "github.com/aws/aws-sdk-go-v2/aws" | ||
| awsconfig "github.com/aws/aws-sdk-go-v2/config" | ||
| "github.com/aws/aws-sdk-go-v2/service/ec2" | ||
| ) | ||
|
|
||
| type ec2Client interface { | ||
| DescribeInstances( | ||
| ctx context.Context, | ||
| params *ec2.DescribeInstancesInput, | ||
| optFns ...func(*ec2.Options), | ||
| ) (*ec2.DescribeInstancesOutput, error) | ||
|
|
||
| TerminateInstances( | ||
| ctx context.Context, | ||
| params *ec2.TerminateInstancesInput, | ||
| optFns ...func(*ec2.Options), | ||
| ) (*ec2.TerminateInstancesOutput, error) | ||
| } | ||
|
|
||
| type awsClients struct { | ||
| ec2 func() ec2Client | ||
| } | ||
|
|
||
| func newAWSClientsFromConfig(cfg *aws.Config) *awsClients { | ||
| return &awsClients{ | ||
| ec2: func() ec2Client { return ec2.NewFromConfig(*cfg) }, | ||
| } | ||
| } | ||
|
|
||
| const awsRegion = "us-west-2" | ||
|
|
||
| func newAWSClients(ctx context.Context) (*awsClients, error) { | ||
| cfg, err := awsconfig.LoadDefaultConfig( | ||
| ctx, awsconfig.WithRegion(awsRegion), | ||
| ) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return newAWSClientsFromConfig(&cfg), nil | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| package reefd | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "log" | ||
| "sort" | ||
| "time" | ||
|
|
||
| "github.com/aws/aws-sdk-go-v2/aws" | ||
| "github.com/aws/aws-sdk-go-v2/service/ec2" | ||
| "github.com/aws/aws-sdk-go-v2/service/ec2/types" | ||
| ) | ||
|
|
||
| type reaper struct { | ||
| ec2 ec2Client | ||
| nowFunc func() time.Time | ||
| } | ||
|
|
||
| func newReaper(ec2 ec2Client) *reaper { | ||
| return &reaper{ec2: ec2} | ||
| } | ||
|
|
||
| func (r *reaper) now() time.Time { | ||
| if r.nowFunc != nil { | ||
| return r.nowFunc() | ||
| } | ||
| return time.Now() | ||
| } | ||
|
|
||
| func (r *reaper) setNowFunc(f func() time.Time) { | ||
| r.nowFunc = f | ||
| } | ||
|
|
||
| func (r *reaper) listDeadWindowsInstances(ctx context.Context) ([]string, error) { | ||
| filters := []types.Filter{{ | ||
| Name: aws.String("tag:BuildkiteQueue"), | ||
| Values: []string{"*windows*"}, | ||
| }, { | ||
| Name: aws.String("instance-state-code"), | ||
| Values: []string{ | ||
| "0", // pending | ||
| "16", // running | ||
| }, | ||
| }} | ||
| const maxResults = 500 | ||
| input := &ec2.DescribeInstancesInput{ | ||
| Filters: filters, | ||
| MaxResults: aws.Int32(maxResults), | ||
| } | ||
| result, err := r.ec2.DescribeInstances(ctx, input) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("describe instances: %w", err) | ||
| } | ||
|
|
||
| const instanceAgeLimit = -4 * time.Hour | ||
|
|
||
| cut := r.now().Add(instanceAgeLimit) | ||
|
|
||
| var instances []string | ||
| for _, r := range result.Reservations { | ||
| for _, i := range r.Instances { | ||
| if i.LaunchTime.Before(cut) { | ||
| instances = append(instances, *i.InstanceId) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| sort.Strings(instances) | ||
|
|
||
| return instances, nil | ||
| } | ||
|
|
||
| func (r *reaper) terminateInstances(ctx context.Context, ids []string) error { | ||
| if len(ids) == 0 { | ||
| return nil | ||
| } | ||
| input := &ec2.TerminateInstancesInput{InstanceIds: ids} | ||
| _, err := r.ec2.TerminateInstances(ctx, input) | ||
| return err | ||
| } | ||
|
|
||
| func (r *reaper) listAndReapDeadWindowsInstances(ctx context.Context) (int, error) { | ||
| ids, err := r.listDeadWindowsInstances(ctx) | ||
| if err != nil { | ||
| return 0, err | ||
| } | ||
| if len(ids) == 0 { | ||
| return 0, nil | ||
| } | ||
|
|
||
| log.Printf("terminating %d instances: %v", len(ids), ids) | ||
| if err := r.terminateInstances(ctx, ids); err != nil { | ||
| return 0, err | ||
| } | ||
|
|
||
| return len(ids), nil | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might not happen but is there a limit on what
DescribeInstancesreturns before it starts the next page. Should we do pagination here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, that is a good point. let me have a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a
MaxResultsof 500. we will rerun the reaper repeatedly until it terminates nothing.