Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] de-glob entries that are not patterns #50199

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aslonnie
Copy link
Collaborator

@aslonnie aslonnie commented Feb 3, 2025

for grpc_common_lib

@aslonnie aslonnie requested review from jjyao and dentiny February 3, 2025 21:51
Copy link
Contributor

@dentiny dentiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have bazel beautifier into our CI/pre-commit hook?
https://github.com/bazelbuild/buildtools/blob/main/buildifier/README.md

@aslonnie aslonnie added go add ONLY when ready to merge, run all tests and removed go add ONLY when ready to merge, run all tests labels Feb 4, 2025
for `grpc_common_lib`

Signed-off-by: Lonnie Liu <[email protected]>
@aslonnie aslonnie force-pushed the lonnie-250203-deglob branch from 6c32cc9 to 9b03e7a Compare February 4, 2025 04:54
@aslonnie
Copy link
Collaborator Author

aslonnie commented Feb 4, 2025

Should we have bazel beautifier into our CI/pre-commit hook? https://github.com/bazelbuild/buildtools/blob/main/buildifier/README.md

sure, good idea.

@aslonnie aslonnie added the go add ONLY when ready to merge, run all tests label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants