Skip to content

[ci] remove other deprecated modes in cond test script #50191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 4, 2025
Merged

[ci] remove other deprecated modes in cond test script #50191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7dd533c
[ci] remove other deprecated modes in cond test script
aslonnie Feb 3, 2025
a24b906
Merge branch 'master' into lonnie-250203-condtest2
aslonnie Feb 3, 2025
cc6df8f
Merge branch 'master' into lonnie-250203-condtest2
aslonnie Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/ci_tags_from_change.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ if [[ "${RAYCI_RUN_ALL_TESTS:-}" == "1" || "${BUILDKITE_BRANCH:-}" == "master" |
exit 0
fi

exec python ci/pipeline/determine_tests_to_run.py --output rayci_tags
exec python ci/pipeline/determine_tests_to_run.py
23 changes: 7 additions & 16 deletions ci/pipeline/determine_tests_to_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
from __future__ import absolute_import, division, print_function

import argparse
import json
import os
import re
import subprocess
Expand Down Expand Up @@ -49,9 +48,6 @@ def get_commit_range():
assert os.environ.get("BUILDKITE")

parser = argparse.ArgumentParser()
parser.add_argument(
"--output", type=str, help="json, rayci_tags or envvars", default="envvars"
)
args = parser.parse_args()

RAY_CI_ML_AFFECTED = 0
Expand Down Expand Up @@ -434,17 +430,12 @@ def get_commit_range():
# Used by buildkite log format
pairs = [item.split("=") for item in output_string.split(" ")]
affected_vars = [key for key, affected in pairs if affected == "1"]
if args.output.lower() == "json":
print(json.dumps(affected_vars))
elif args.output.lower() == "rayci_tags":

def f(s):
if s.startswith("RAY_CI_"):
s = s[7:]
if s.endswith("_AFFECTED"):
s = s[:-9]
return s.lower()
def to_tag(s):
if s.startswith("RAY_CI_"):
s = s[7:]
if s.endswith("_AFFECTED"):
s = s[:-9]
return s.lower()

print(" ".join(list(map(f, affected_vars))))
else:
print(output_string)
print(" ".join(list(map(to_tag, affected_vars))))