[RLlib] APPO accelerate vol 02: Various enhancements. #50162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sven1977 <[email protected]>
sven1977
added
rllib
Signed-off-by: sven1977 <[email protected]>
simonsays1980
approved these changes
Jan 31, 2025
| # Default is to have a learner thread. | ||
| if not hasattr(self, "_learner_thread_in_queue"): | ||
| self._learner_thread_in_queue = deque(maxlen=self.config.learner_queue_size) | ||
|
|
||
| # Create and start the GPU loader thread(s). | ||
| if self.config.num_gpus_per_learner > 0: | ||
| self._gpu_loader_threads = [ |
There was a problem hiding this comment.
Let's name the threads for better debugging.
| class _GPULoaderThread(threading.Thread): | ||
| def __init__( | ||
| self, | ||
| *, |
There was a problem hiding this comment.
Use the name argument here and pass it to super
| @@ -166,9 +225,8 @@ def step(self): | |||
| ma_batch_on_gpu = self._in_queue.sample() | |||
| else: | |||
| # Queue is empty: Sleep a tiny bit to avoid CPU-thrashing. | |||
There was a problem hiding this comment.
Usually the scheduler makes a good job in providing runtime to each process. This while loop could slow things down and in worst case block.
There was a problem hiding this comment.
I do think we have to sleep here (or at least be careful with removing this logic).
The "queue" here is a deque, which doesn't have the GIL-release logic of a Queue.get(). Looping here with while True: without sleeping would certainly harm performance.
…_accelerate_02_various_enhancements
Signed-off-by: sven1977 <[email protected]>
…_accelerate_02_various_enhancements
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APPO accelerate vol 02: Various enhancements.
ray.waitrequests.Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.