-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Implement py_executable support for runtime environments to enable better UV support #50160
Open
pcmoritz
wants to merge
26
commits into
master
Choose a base branch
from
wrap-runtime-env
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+334
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcmoritz
changed the title
[Core] Implement generic runtime environment plugin to wrap worker
[Core] Implement py_executable support for runtime environments to enable better UV support
Feb 2, 2025
edoakes
reviewed
Feb 3, 2025
edoakes
reviewed
Feb 3, 2025
edoakes
reviewed
Feb 3, 2025
edoakes
reviewed
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good pending uv
e2e test
edoakes
approved these changes
Feb 3, 2025
import emoji | ||
return emoji.emojize("Ray rocks :thumbs_up:") | ||
|
||
assert ray.get(emojize.remote()) == "Ray rocks 👍" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This implements a very simple runtime environment plugin that allows e.g. using the
uv run
command for dependency handling (but could also be useful for wrapping the worker command e.g. with a profiler or debugger).Very simple example:
with
Slightly more complex example with
pyproject.toml
in the working_dir (see https://docs.astral.sh/uv/guides/scripts):with
pyproject.toml:
text.py
And the dependencies can also be locked with
uv lock
.Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.