Skip to content

Add Helm chart unittests to CI #3280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2025
Merged

Add Helm chart unittests to CI #3280

merged 1 commit into from
Apr 11, 2025

Conversation

ChenYi015
Copy link
Contributor

Why are these changes needed?

Related issue number

Close #3279

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@ChenYi015 ChenYi015 mentioned this pull request Apr 7, 2025
Merged
4 tasks
@ChenYi015 ChenYi015 force-pushed the chore/helm-unittest branch from f123229 to 499e3be Compare April 10, 2025 05:42
@kevin85421
Copy link
Member

Are there any dependencies between this PR and others? Should I follow any specific order when reviewing them?

@ChenYi015
Copy link
Contributor Author

Are there any dependencies between this PR and others? Should I follow any specific order when reviewing them?

@kevin85421 There is no need to review this PR with a specific order. You could approve the workflow to run and check whether it can run successfully.

@kevin85421
Copy link
Member

This PR doesn't include commit #3253, so no tests are running. Let's merge it and see how it goes.

image

kevin85421
kevin85421 approved these changes Apr 11, 2025
View reviewed changes
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChenYi015 would you mind opening a follow up PR to add some instructions about how to run the Helm chart unit tests in https://github.com/ray-project/kuberay/blob/master/ray-operator/DEVELOPMENT.md#end-to-end-local-development-process-on-kind?

@kevin85421 kevin85421 merged commit 113909f into ray-project:master Apr 11, 2025
21 checks passed
@kevin85421
Copy link
Member

On the master branch:

image

@ChenYi015 ChenYi015 deleted the chore/helm-unittest branch April 12, 2025 02:32
@ChenYi015
Copy link
Contributor Author

@ChenYi015 would you mind opening a follow up PR to add some instructions about how to run the Helm chart unit tests in https://github.com/ray-project/kuberay/blob/master/ray-operator/DEVELOPMENT.md#end-to-end-local-development-process-on-kind?

Sure, I will update it recently.

win5923 pushed a commit to win5923/kuberay that referenced this pull request Apr 27, 2025
@ChenYi015 @win5923
Add Helm chart unittests to CI (ray-project#3280)
586f6d6 
Signed-off-by: Yi Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin85421 kevin85421 kevin85421 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Add Helm chart unit tests to CI
2 participants
@ChenYi015 @kevin85421