[refactor][plugin] RayClusterSpecObject #3238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidxia
commented
Mar 27, 2025
Comment on lines
-37
to
-41
| type RayClusterYamlObject struct { | ||
| ClusterName string | ||
| Namespace string | ||
| Labels map[string]string | ||
| Annotations map[string]string |
There was a problem hiding this comment.
I folded this struct into RayClusterSpecObject.
davidxia
commented
Mar 27, 2025
There was a problem hiding this comment.
#3225's very similar RayClusterConfig and rayClusterSpecObjectFromConfig() motivated this PR.
davidxia
force-pushed
the
refactor1
branch
2 times, most recently
from
56968e6 to
cfaabee
Compare
4 tasks
MortalHappiness
approved these changes
Mar 28, 2025
andrewsykim
approved these changes
Mar 31, 2025
|
rebased to fix conflicts |
andrewsykim
reviewed
Mar 31, 2025
| WorkerMemory string | ||
| WorkerEphemeralStorage string | ||
| WorkerReplicas int32 | ||
| Context *string `yaml:"context,omitempty"` |
There was a problem hiding this comment.
Why YAML tags in both RayClusterSpecObject and RayClusterConfig?
There was a problem hiding this comment.
I don't think RayClusterConfig is introduced yet? I will rename this struct to RayClusterConfig in #3225.
so we can use it for [this proposed cluster config schema][1]. We change in a backwards-compatible way to support multiple worker groups and other fields in the schema. [1]: https://docs.google.com/document/d/18V5_7SGUzS0LGlaJB7xus04omyr3drKkK4vV6Kz14jY/edit?tab=t.0#heading=h.tuqyq1b6b2x7 Signed-off-by: David Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so we can use it for this proposed cluster config schema. We change in a backwards-compatible way to support multiple worker groups and other fields in the schema.
Checks